Fix linear selection on Python 3.12 - #25
Conversation
Signed-off-by: russlan23 <rrusslanjr@gmail.com>
|
@russlan23 thank you so much for this PR and the fix. Coincidently, we were also just in the middle of updating this specific issue. Please stay tuned for an update shortly. We might use this PR (or, close this one and make an version upgrade internally). Either way, this is going to be fixed very soon. cc: @rbaral @takojunior |
|
@russlan23 thanks for the suggestion you provided. This and with some other minimal fix in text_based.py (for upgraded pandas due to Python 3.12), I was able to run the test cases for Python 3.12. and Python 3.10. I can bundle these two fixes and some housekeeping work into a new PR. We also need to add some documentation about the fix. It would have been better to have minimal code changes, such as using a different solver. However, that required some changes in the test cases. CC @skadio @takojunior |
3 participants
Fixes #24.
scikit-learn removed the multi_class parameter from LogisticRegression. This keeps the existing liblinear one-vs-rest behavior by wrapping the two logistic estimators in OneVsRestClassifier, then preserves the existing coefficient aggregation when computing feature scores.
Validation: